Support gRPC connection options for retry and timeout#1987
Merged
Conversation
Contributor
|
Looks more or less reasonable to me. The mypy failure doesn't look related to this PR? |
juergbi
force-pushed
the
juerg/grpc-settings
branch
3 times, most recently
from
f9f2c1e to
c94baa2
Compare
juergbi
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow and
gtristan
as code owners
Contributor
Author
It was related to the regeneration of protobuf code with updated tooling. Fixed now. |
juergbi
force-pushed
the
juerg/grpc-settings
branch
from
c94baa2 to
be2cf81
Compare
abderrahim
reviewed
Mar 26, 2025
abderrahim
approved these changes
Mar 26, 2025
Contributor
abderrahim
left a comment
abderrahim
left a comment
There was a problem hiding this comment.
Otherwise looks good.
The versions are taken from requirements.txt. This adds generated .pyi files for mypy.
juergbi
force-pushed
the
juerg/grpc-settings
branch
from
be2cf81 to
d12f7bb
Compare
juergbi
force-pushed
the
juerg/grpc-settings
branch
from
d12f7bb to
228fead
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.